-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document pixels sent by the extension #2875
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments - mostly hoping we can get more descriptions filled out, but otherwise LGTM!
{ | ||
"key": "duck_address_last_used", | ||
"description": "", | ||
"pattern": "[0-9]{4}-[0-9]{2}-[0-9]{2}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use the date
format instead, for readability?
}, | ||
{ | ||
"key": "jsPerformance", | ||
"description": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a small description, e.g., "metrics gathered via the Performance web API." and maybe links in the comments to https://developer.mozilla.org/en-US/docs/Web/API/Performance/getEntriesByType and https://github.com/duckduckgo/content-scope-scripts/blob/main/injected/src/features/breakage-reporting/
}, | ||
{ | ||
"key": "lastSentDay", | ||
"description": "If a report for the same site was previously sent by this user, this indicates the day of that report." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Date format again?
}, | ||
{ | ||
"key": "noActionRequests", | ||
"description": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use "hostnames of requests that were not present in the blocklist" for the description? (From https://app.asana.com/0/1198207348643509/1200202563872939)
Reviewer: @nshuba
Asana: https://app.asana.com/0/0/1208014515268142/f
Description: