Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using XRay in Firefox #2852

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

muodov
Copy link
Member

@muodov muodov commented Dec 11, 2024

Reviewer:

Description:

https://app.asana.com/0/1201614831475344/1207277833550158/f
Firefox now supports execution worlds for content scripts in their MV2 manifest. This allows us to remove xray code. See also

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@muodov muodov force-pushed the max/firefox-isolated-content-script branch from 62a1bda to be28476 Compare December 11, 2024 15:27
@muodov
Copy link
Member Author

muodov commented Dec 11, 2024

@sammacbeth the test failures seem unrelated, the amp ones seem to be broken in main too, and others do pass locally. I assume it's not related to the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants