-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added webCompat as a docs page #690
base: main
Are you sure you want to change the base?
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Some errors in the build though. |
* | ||
* A suite of individual 'fixes' | ||
* | ||
* - {@link default.windowSizingFix Window Sizing Fix} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda shame we need to do this, is there no other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's not the nicest, but it is checked at build time which makes it slightly better.
another way, would be to encapsulate each sub feature into it's own class/module - but I think that might be going further than you want (in terms of code change for docs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, we can omit the list - it was just a nice way to list them when you land on the top-level webCompat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind, just don't really like having manual steps and loads of boilerplate to make docs happy. I'll let you make the judgement here, I agree splitting to separate classes seems a little overkill too, but I don't mind if there's other benefits.
a5dc2a4
to
5f7f31a
Compare
5c50bb2
to
5140918
Compare
Converted to draft |
Added some basic support for documenting Web Compat features - something to build upon