Skip to content
This repository has been archived by the owner on Nov 19, 2021. It is now read-only.

IA Pages - automatically update dev_milestone #1420

Open
wants to merge 1 commit into
base: dev-ia-pages
Choose a base branch
from

Conversation

MariagraziaAlastra
Copy link
Member

Description :

Based on other fields values (perl_module, production_state, blockgroup, deployment_state, and the current dev_milestone) we should be able to automatically update the dev_milestone field for any IA.

This PR also introduces a new dev_milestone value: "offline".

How the dev_milestone will be determined:

  • online, live, blockgroup, perl_module, deployment_state = live
  • online, live, no perl_module/blockgroup/deployment_state = offline
  • offline, planning/development, no blockgroup, no deployment_state = no change (still planning or development)
  • offline, deprecated = no change
  • offline, complete, no deployment_state = complete
  • offline, planning/development, blockgroup = testing
  • offline, live, blockgroup, deployment_state = offline
  • offline, complete, blockgroup, deployment_state = no change

To do:

  • Make sure all the possible cases are taken into account.
  • SQL to automatically update existing IAs.
  • Tweak the ghIssues.pl script to use the new statuscheck function when automatically updating the dev_milestone
  • Back end tests
Reviewer notes :
References issues / PRs:

Who should be informed of this change?
Does this change have significant privacy, security, performance or deployment implications?
Checklist :
  • Back end tests (perl, scripts)
  • Front end tests (js, integration)
  • Browser verification
    • IE
    • Chrome
    • Firefox
    • Safari
    • Opera
  • Mobile verification
    • iOS
    • Android

}
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic nightmare

@zachthompson
Copy link
Contributor

online, live, no perl_module/blockgroup/deployment_state = offline

Probably should be something other than "offline" since it indicates an inconsistent state.

@zachthompson
Copy link
Contributor

In general I don't think we are determining dev_milestone here. Yes, we've used that column in the past for status but

  1. It can be edited
  2. It probably can and should be modifiable independently of the status, e.g. we could set it to dev when making an enhancement even though still online.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants