Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add per cpu ringbuffer #16

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add per cpu ringbuffer #16

wants to merge 2 commits into from

Conversation

dshulyak
Copy link
Owner

@dshulyak dshulyak commented Jul 28, 2024

one serious problem with it, i have to lower memory per ringbuffer, otherwise paged memory for profiler grows unreasonably.
if there is a burst of events on single cpu i will be missing them, when i wouldn't miss them if i was using single buffer.

contention on ringbuffer also doesn't appear to be an issue, maybe i need better tests for that, but overall i don't see a reason to merge this

2024-07-28T13:30:46.311491Z  INFO past::bpf_profile: BPF PROFILE:
program         | duration s      | runtime s       | busy %          | runtime cnt     | collected cnt   | collected latency ns
profile         | 10.4589         | 0.0037          | 0.04            | 24840           | 0               | inf            
exec            | 10.4589         | 0.0000          | 0.00            | 2               | 1               | 31971.00       
switch          | 10.4589         | 0.0259          | 0.25            | 132442          | 36              | 719661.64      
rss             | 10.4589         | 0.0599          | 0.57            | 2862210         | 87              | 688622.77

@dshulyak dshulyak force-pushed the master branch 3 times, most recently from 23055cd to cec2d99 Compare August 8, 2024 11:52
@dshulyak dshulyak marked this pull request as draft December 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant