Sender must be a part of mail list

[derbronko]

No description provided.

[dschmidt]

Please make it work :-P

[dschmidt]

Look closer at the link I sent you https://github.com/dschmidt/billo/blob/master/src/billo.php#L43

You need to handle an addressList here, as there could be multiple from values.

Apart from that: there is no $list in this scope.
You could probably handle this better here:

billo/src/billo.php

Line 26 in 08f5dfc

}

with code similar to this:

     $members = $listsConfig->getMembers($list->getEmail());                                                                                     
                                                                                                                                                 
     // Check at least one of the senders ("from") is subscribed to the list                                                                     
     $subscribed = false;                                                                                                                        
     foreach($message->getHeader('from')->getAddressList() as $from) {                                                                           
       if (in_array($from->getEmail(), array_keys($members))) {                                                                                              
         $subscribed = true;                                                                                                                     
       }                                                                                                                                         
     }                                                                                                                                           
     if(!$subscribed) {                                                                                                                          
       continue;                                                                                                                                 
     } 

Please test, I haven't :)

[dschmidt]

There's one bug, so this won't work and I'd like the logic to be moved out of billo.php but apart from that this looks really good now

[dschmidt]

We could move this logic to the ListsConfigParser. Naming the function is probably the hardest part :-D
... and then:

Suggested change

	}
	if(!$listsConfig->isAnyAddressMemberOfList($message->getHeader('from')->getAddressList(), $list->getEmail())) {
	continue;
	}

Keeps the complexity of this function lower and gives us a chance to unit test it...

[dschmidt]

You need to pass the list name to isMember not the members themselves.

Suggested change

	if ($listsConfig->isMember($from->getEmail(), $members)) {
	if ($listsConfig->isMember($from->getEmail(), $list->getEmail())) {