Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSC_xGroupResource: Fix for the issue #750 #754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielmiu
Copy link

@danielmiu danielmiu commented Oct 11, 2022

Pull Request (PR) description

  • This PR implements proposed workaround for the issue 750

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@danielmiu
Copy link
Author

SDedik is the original provider of the workaround.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (475885c) to head (0117f60).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...sources/DSC_xGroupResource/DSC_xGroupResource.psm1 0% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #754   +/-   ##
===================================
- Coverage    72%    72%   -1%     
===================================
  Files        30     30           
  Lines      4427   4432    +5     
===================================
- Hits       3213   3199   -14     
- Misses     1214   1233   +19     
Files with missing lines Coverage Δ
...sources/DSC_xGroupResource/DSC_xGroupResource.psm1 69% <0%> (-1%) ⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group: Unable to add Different forest User to Local Group
1 participant