Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSC_xGroupResource: Fix for the issue #750 #751

Closed
wants to merge 6 commits into from
Closed

DSC_xGroupResource: Fix for the issue #750 #751

wants to merge 6 commits into from

Conversation

danielmiu
Copy link

@danielmiu danielmiu commented Oct 6, 2022

Pull Request (PR) description

  • This PR implements proposed workaround for the issue 750

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@danielmiu
Copy link
Author

danielmiu commented Oct 6, 2022

Just wanted to point out that all merits go to SDedikas he is the original provider of the workaround.

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Oct 7, 2022
@PlagueHO
Copy link
Member

PlagueHO commented Oct 7, 2022

Hi @danielmiu - thanks for submitting this! It looks like the CI is failing due to the pipelines not being updated to remove the old WS 2016 images. I've created an issue to get this resolved. Will try and do this later on today (it's a simple enough issue): #752

You'll then need to rebase onto main once it's merged. Sorry about that.

@PlagueHO
Copy link
Member

I've created the PR to fix the pipeline: #753

Once merged you can rebase onto main and it should fix the CI.

@johlju
Copy link
Member

johlju commented Oct 10, 2022

The PR to fix CI has been merged. This PR can nbe rebased now.

@danielmiu
Copy link
Author

danielmiu commented Oct 10, 2022

Done, hope I didn't do a mess while rebasing :)

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #751 (0653909) into main (475885c) will decrease coverage by 0%.
The diff coverage is 33%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #751   +/-   ##
===================================
- Coverage    72%    72%   -1%     
===================================
  Files        30     30           
  Lines      4427   4432    +5     
===================================
- Hits       3213   3199   -14     
- Misses     1214   1233   +19     
Impacted Files Coverage Δ
...sources/DSC_xDSCWebService/DSC_xDSCWebService.psm1 88% <ø> (ø)
...sources/DSC_xGroupResource/DSC_xGroupResource.psm1 69% <0%> (-1%) ⬇️
...sionConfiguration/DSC_xPSSessionConfiguration.psm1 0% <ø> (ø)
...ces/DSC_xPackageResource/DSC_xPackageResource.psm1 76% <ø> (-4%) ⬇️
...urces/DSC_xScriptResource/DSC_xScriptResource.psm1 100% <ø> (ø)
...ces/DSC_xServiceResource/DSC_xServiceResource.psm1 93% <ø> (ø)
...Resources/DSC_xUserResource/DSC_xUserResource.psm1 53% <ø> (ø)
...urces/DSC_xWindowsFeature/DSC_xWindowsFeature.psm1 86% <ø> (ø)
.../xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1 0% <ø> (ø)
...xEnvironmentResource/DSC_xEnvironmentResource.psm1 91% <100%> (ø)
... and 1 more

@PlagueHO
Copy link
Member

@danielmiu, really strange: it looks like it's rebased fine, but the azure-pipelines.yml is compared against the old one before I made the CI fix. Did you fetch main from upstream before you rebased?

@danielmiu
Copy link
Author

Yes, I did. Would it be cleaner if I just create a new PR? There aren’t that many changes required to fix the issue.

@PlagueHO
Copy link
Member

Hi @danielmiu - maybe. If you're happy to?

@danielmiu danielmiu closed this by deleting the head repository Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group: Unable to add Different forest User to Local Group
3 participants