-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSC_xGroupResource: Fix for the issue #750 #751
DSC_xGroupResource: Fix for the issue #750 #751
Conversation
Just wanted to point out that all merits go to SDedikas he is the original provider of the workaround. |
Hi @danielmiu - thanks for submitting this! It looks like the CI is failing due to the pipelines not being updated to remove the old WS 2016 images. I've created an issue to get this resolved. Will try and do this later on today (it's a simple enough issue): #752 You'll then need to rebase onto main once it's merged. Sorry about that. |
I've created the PR to fix the pipeline: #753 Once merged you can rebase onto main and it should fix the CI. |
The PR to fix CI has been merged. This PR can nbe rebased now. |
Done, hope I didn't do a mess while rebasing :) |
@danielmiu, really strange: it looks like it's rebased fine, but the |
Yes, I did. Would it be cleaner if I just create a new PR? There aren’t that many changes required to fix the issue. |
Hi @danielmiu - maybe. If you're happy to? |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is