Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xGroup: add NewName property #718

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gaelicWizard
Copy link

@gaelicWizard gaelicWizard commented May 23, 2021

Pull Request (PR) description

Adds optional parameter NewName to xGroup resources to allow setting SamAccountName property separately. This requires that GroupName be specified using something other than the SamAccountName, e.g. SID.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Add NewName property to allow setting the name of the group; this requires that the GroupName property be specified with something other than the SamAccountName (e.g., the SID).
@gaelicWizard gaelicWizard force-pushed the xGroupSamAccountName branch from af0319b to 6a6f929 Compare May 23, 2021 04:35
@gaelicWizard gaelicWizard force-pushed the xGroupSamAccountName branch from 6a6f929 to c8bf5d0 Compare May 23, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant