Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added site information to CI and alpha job. #671

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Added site information to CI and alpha job. #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
015e772
Added site information to CI.
AlexSkrypnyk May 29, 2024
288bb0a
Fixed CI using dev dependencies.
AlexSkrypnyk May 29, 2024
df6816c
Added `alpha` testing.
AlexSkrypnyk May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

matrix:
php-versions: ['8.3']
drupal-release: ['beta', 'dev']
drupal-release: ['alpha', 'beta', 'dev']
composer-channel: ['stable', 'snapshot']

steps:
Expand Down Expand Up @@ -70,23 +70,30 @@ jobs:
test -d web/libraries/dropzone

- name: Override Drupal version to dev for testing dev releases
if: matrix.drupal-release == 'dev'
if: matrix.drupal-release == 'dev' || matrix.drupal-release == 'beta'
run: |
composer config minimum-stability dev
composer --verbose require --no-update drupal/core-recommended:11.0.x-dev
composer --verbose require --no-update --dev drupal/core-dev:11.0.x-dev
composer config minimum-stability ${{ matrix.drupal-release }}
composer config prefer-stable false
composer --verbose require --no-update drupal/core-composer-scaffold:^11@${{ matrix.drupal-release }}
composer --verbose require --no-update drupal/core-recommended:^11@${{ matrix.drupal-release }}
composer --verbose require --no-update --dev drupal/core-dev:^11@${{ matrix.drupal-release }}
# Remove the line below once the package is out of `alpha`.
[[ ${{ matrix.drupal-release }} == 'beta' ]] && composer require chi-teck/drupal-code-generator:^4@alpha
Copy link
Collaborator Author

@AlexSkrypnyk AlexSkrypnyk May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unfortunate but a required temporary hack to unblock beta testing.

if consumer projects want to use minimum-stability: beta before this package is in beta - they can explicitly include this package in their composer.json using exactly this way

composer --verbose update

- name: Install site
run: ./vendor/bin/drush site-install --verbose --yes --db-url=sqlite://tmp/site.sqlite

- name: Show site information
run: ./vendor/bin/drush status

- name: Start server
run: |
./vendor/bin/drush runserver "$SIMPLETEST_BASE_URL" &
until curl -s "$SIMPLETEST_BASE_URL"; do true; done > /dev/null

- name: Run a single unit test to verify the testing setup
run: ./vendor/bin/phpunit -c ./web/core $(pwd)/web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php
run: ./vendor/bin/phpunit -c ./web/core "$(pwd)/web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fixing GHA linting issues (using actionlint).


# Using outdated Composer version to test the Composer version constraint.
test-composer:
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
"require": {
"composer/installers": "^2.1",
"cweagans/composer-patches": "^1.7",
"drupal/core-composer-scaffold": "^11@beta",
"drupal/core-recommended": "^11@beta",
"drupal/core-composer-scaffold": "^11@alpha",
leymannx marked this conversation as resolved.
Show resolved Hide resolved
"drupal/core-recommended": "^11@alpha",
"drush/drush": "^13@beta",
"oomphinc/composer-installers-extender": "^2.0",
"vlucas/phpdotenv": "^5.1",
"webflo/drupal-finder": "^1.2"
},
"require-dev": {
"drupal/core-dev": "^11@beta",
"drupal/core-dev": "^11@alpha",
"ergebnis/composer-normalize": "^2.42"
},
"conflict": {
Expand Down
Loading