validate received union tag #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested that this branch works well with the quadplane-can simulated vehicle on ArduPilot master (9c1fe4e1). It flies and all the sensors work properly. Also tested that the DroneCAN GUI tool works properly as that seems to be the biggest user of unions. |
tridge
requested changes
Jul 21, 2024
Avoids setting a non-existent union value and causing undefined behavior. Additionally be sure bit_ofs is updated after decoding the tag before the error is raised. This matches all other uses of canardDecodeScalar.
tpwrules
force-pushed
the
pr/validate-union-tag
branch
from
b6d5905 to
24b31ec
Compare
tridge
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids setting a non-existent union value and causing undefined behavior.
Additionally be sure bit_ofs is updated after decoding the tag before the error is raised. This matches all other uses of canardDecodeScalar.