Fix decoding of compound TAO elements #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if any bits were left, the loop would try to decode another element. However, elements of arrays eligible for TAO must be >= 8 bits, so the decode would over-run by an element if 7 or fewer bits were left and the decode would fail due to the length check. Fix this by only decoding until there are 7 or fewer bits left. Not triggered by any message in the DSDL repo, but it is easy to create one which would be incorrectly decoded, e.g. ``` void1 pad uavcan.equipment.gnss.Fix2 fix ```
tridge
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if any bits were left, the loop would try to decode another element. However, elements of arrays eligible for TAO must be >= 8 bits, so the decode would over-run by an element if 7 or fewer bits were left and the decode would fail due to the length check.
Fix this by only decoding until there are 7 or fewer bits left.
Not triggered by any message in the DSDL repo, but it is easy to create one which would be incorrectly decoded, e.g.