add support for github pull request comment webhook parsing #33
Conversation
|
|
| return nil, err | ||
| } | ||
| dst := convertPullRequestReviewCommentHook(src) | ||
| return dst, nil |
There was a problem hiding this comment.
I believe this function should set the action to one of scm.ActionCreate, scm.ActionUpdate, scm.ActionDelete
| @@ -356,6 +391,35 @@ func convertPullRequestHook(src *pullRequestHook) *scm.PullRequestHook { | |||
| } | |||
| } | |||
|
|
|||
| func convertPullRequestReviewCommentHook(src *pullRequestReviewCommentHook) *scm.PullRequestCommentHook { | |||
There was a problem hiding this comment.
I believe this should return a ReviewCommentHook. The distinction is that a pull request comment is when you comment on the issue (although github treats pull requests the same as issues, other providers do not, so we abstract). The review comment is when you comment on code. The ReviewCommentHook also stores a Review information such as file name and line number.
fix: avoid failures on bitbucket cluster
|
Is this going stale? I'm currently using go-github to parse issue comments for pull requests but considering to add such support for go-scm. Is the intention of this PR to support review comment or issue comments on pull requests? Should I wait for this PR? Thanks for an update :) |
No description provided.