Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests for non China based people #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix tests for non China based people #269

wants to merge 2 commits into from

Conversation

ccoVeille
Copy link
Contributor

  • tests: Playing with Carbon Default is dangerous.
  • ci: tests were written by someone in PRC timezone

Fixes #268

@ccoVeille
tests: Playing with Carbon Default is dangerous.
7117a5e 
These variable are global. It has consequences.

People launching tests another timezone where facing random issues.
It was random because the tests are launched in different order on each run.

This was hidden by the CI forcing the timezone to PRC, and impossible to see by
someone working in PRC timezone.
@ccoVeille
ci: tests were written by someone in PRC timezone
83a65e5 
Nothing was working if you were not in this timezone.

The CI was forced in this timezone, but it was uneasy to catch.

Now all tests are launched in the PRC timezone.

We are using TestMain to sort this out.
https://pkg.go.dev/testing#hdr-Main
@ccoVeille
Copy link
Contributor Author

@gouguoyin could you review?

@gouguoyin
Copy link
Collaborator

@gouguoyin could you review?

Yes, but there are too many changes. I need to verify carefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing tests
2 participants
@ccoVeille @gouguoyin