Merge pull request #28 from drekbour/lodash-fix

Fix build broken by lodash upgrade
drewnoakes · Jan 1, 2020 · 5c97054 · 5c97054
2 parents 9e38ebc + 7cc2e2a
commit 5c97054
Show file tree

Hide file tree

Showing 5 changed files with 2,110 additions and 564 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,5 @@
 .idea
 node_modules/
 dist/
+package-lock.json
+
diff --git a/gulpfile.js b/gulpfile.js
@@ -16,7 +16,7 @@ gulp.task('lib', function() {
 	return gulp.src(
 		[
 			'node_modules/jquery/dist/jquery.min.js',
-			'node_modules/lodash/dist/lodash.min.js',
+			'node_modules/lodash/lodash.min.js',
 			'node_modules/handlebars/dist/handlebars.min.js'
 		])
         .pipe(gulp.dest('dist/scripts/lib'))
@@ -53,4 +53,4 @@ gulp.task('img', function() {
         .pipe(gulp.dest('dist/img'))
 });
 
-gulp.task('default', ['app', 'lib', 'lib-min', 'styles', 'index', 'img']);
+gulp.task('default', gulp.parallel('app', 'lib', 'lib-min', 'styles', 'index', 'img'));
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
     "requirejs": "2.1.11"
   },
   "devDependencies": {
-    "gulp": "^3.9.1",
+    "gulp": "^4.0.2",
     "gulp-rename": "^1.2.2",
     "gulp-uglify": "^2.1.2"
   }

diff --git a/src/scripts/app/FixParser.js b/src/scripts/app/FixParser.js
@@ -38,7 +38,7 @@ define(
 
                 var classes = [];
 
-                if (_.contains(data.systemFieldIds, fieldId)) {
+                if (_.includes(data.systemFieldIds, fieldId)) {
                     classes.push("system-field");
                 }