[Misc] optimize BigDecimal.divide #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandlerwang
reviewed
Aug 1, 2024
| Class<BigDecimal> clazz = BigDecimal.class; | ||
| Field optField = clazz.getDeclaredField("opt"); | ||
| optField.setAccessible(true); | ||
| SecureRandom random = new SecureRandom(); |
There was a problem hiding this comment.
这里需要加一些边界条件检查，不能全依赖随机测试
There was a problem hiding this comment.
这里需要加一些边界条件检查，不能全依赖随机测试
好的， 增加了下列特殊情况
0.00000000000000D,
123456789.123456789, -123456789.123456789,
1e10, 1e-010, -1e10, -1e-010,
Double.MAX_VALUE, Double.MIN_VALUE,
-Double.MAX_VALUE, -Double.MIN_VALUE
sandlerwang
reviewed
Aug 1, 2024
| @@ -368,6 +368,18 @@ protected StringBuilderHelper initialValue() { | |||
| */ | |||
| private static final BigDecimal ONE_HALF = valueOf(5L, 1); | |||
|
|
|||
| private static boolean opt; | |||
There was a problem hiding this comment.
是否应该在opt声明的时候加上默认值，下面的try-catch没有final语句，如果有一些特殊异常情况可能导致opt没赋上值
weixlu
force-pushed
the
decimal
branch
4 times, most recently
from
7a96e2c to
5f9464c
Compare
weixlu
changed the title
Summary: Use binary search in zero stripping of BigDecimal.divide Testing: jtreg and ci Reviewers: zhuoren.wz, JoshuaZhuwj Issue: #848
sandlerwang
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use binary search in zero stripping of BigDecimal.divide
Testing: jtreg
Reviewers:
Issue: #848