Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GC] Add option G1BarrierSimple to use simple g1 post barrier #829

Merged
merged 1 commit into from
May 31, 2024
Merged

[GC] Add option G1BarrierSimple to use simple g1 post barrier #829

merged 1 commit into from
May 31, 2024

Conversation

mmyxym
Copy link
Collaborator

@mmyxym mmyxym commented May 24, 2024

Summary: Provide option G1BarrierSimple to use simple G1 post barrier for better mutator performance

Testing: CI pipeline

Reviewers: yude, yifeng

Issue: #828

@mmyxym mmyxym requested review from linade and leveretconey May 24, 2024 06:17
linade
linade reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@linade linade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few assertions are missing, e.g.,


void G1ConcurrentRefineThread::run_service() {
  assert(!G1CardMarkOnlyForTrackedRegion && !G1BarrierSkipDCQ, "Concurrent Refinement should be disabled");

leveretconey
leveretconey reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@leveretconey leveretconey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G1BarrierSimple is only supported on aarch64 and x86 now, so maybe it should be disabled on other platform

@linade
Copy link
Collaborator

linade commented May 29, 2024

PtrQueueSet::process_or_enqueue_complete_buffer also had changes in the original patch, wonder if it's missed

@mmyxym
Copy link
Collaborator Author

mmyxym commented May 29, 2024

PtrQueueSet::process_or_enqueue_complete_buffer also had changes in the original patch, wonder if it's missed

Add assertion to check dcqs empty

@mmyxym
Copy link
Collaborator Author

mmyxym commented May 29, 2024

G1BarrierSimple is only supported on aarch64 and x86 now, so maybe it should be disabled on other platform

Add the platform restriction.

@mmyxym
[GC] Add option G1BarrierSimple to use simple g1 post barrier
74f3822 
Summary: Provide option G1BarrierSimple to use simple G1 post barrier for better mutator performance

Testing: CI pipeline

Reviewers: yude, yifeng

Issue: dragonwell-project#828
@mmyxym mmyxym merged commit 831a1b7 into dragonwell-project:master May 31, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leveretconey leveretconey leveretconey approved these changes

@linade linade linade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmyxym @linade @leveretconey