Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running tests in environment with a custom NINJA_STATUS. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikchen
Copy link

Don't leak the environment's NINJA_STATUS leak into the tests, which depend on
setting a custom NINJA_STATUS.

Don't leak the environment's NINJA_STATUS leak into the tests, which depend on
setting a custom NINJA_STATUS.
Copy link
Owner

@dpranke dpranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably isn't the right change; the tests themselves should probably be using a fake environment instead. Do you have time to look into whether that's doable? If not, I can look this evening.

@dpranke
Copy link
Owner

dpranke commented Oct 24, 2018

Bleah, it turns out this is annoyingly complicated and is going to require a serious re-think (that I'd long been putting off) to fix properly. It may be that this is the right short-term fix, but I'll look at it a bit longer to see if there's a better short-term fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants