removed todo

dpla · Mar 26, 2024 · a7e0a09 · a7e0a09
1 parent f57c3a0
commit a7e0a09
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/src/main/scala/dpla/ingestion3/harvesters/oai/refactor/OaiProtocol.scala b/src/main/scala/dpla/ingestion3/harvesters/oai/refactor/OaiProtocol.scala
@@ -7,14 +7,12 @@ class OaiProtocol(oaiConfiguration: OaiConfiguration)
   lazy val endpoint: String = oaiConfiguration.endpoint
   lazy val metadataPrefix: Option[String] = oaiConfiguration.metadataPrefix
 
-  override def listAllRecordPages(): IterableOnce[Either[OaiError, OaiPage]] = {
-    val responseBuilder =
-      new OaiMultiPageResponseBuilder(endpoint, "ListRecords", metadataPrefix)
-
-    val multiPageResponse = responseBuilder.getResponse
-    // TODO: Is there a better way to make a TraversableOnce return type?
-    multiPageResponse.iterator
-  }
+  override def listAllRecordPages(): IterableOnce[Either[OaiError, OaiPage]] =
+    new OaiMultiPageResponseBuilder(
+      endpoint,
+      "ListRecords",
+      metadataPrefix
+    ).getResponse.iterator
 
   override def listAllRecordPagesForSet(
       setEither: Either[OaiError, OaiSet]
@@ -23,7 +21,6 @@ class OaiProtocol(oaiConfiguration: OaiConfiguration)
     val listResponse = setEither match {
       case Left(error) => List(Left(error))
       case Right(set) =>
-
         val responseBuilder = new OaiMultiPageResponseBuilder(
           endpoint,
           "ListRecords",