db query bugfix

[FarukMZKC]

some db query syntax error resolve

[GwynethLlewelyn]

Except for the GROUP BY vs. ORDER BY issue, which I still have some questions about, the rest is essentially 100% correct (and necessary to avoid broken queries!).

[GwynethLlewelyn]

That sounds quite reasonable, considering that task_start_dateis a DATETIME! Fixed on my own fork, too.

[GwynethLlewelyn]

As before... well caught, this is really not correct for a DATETIME.

[GwynethLlewelyn]

I'm a bit confused by this change. 🤔

According to the comment, the decision to use GROUP BY instead of ORDER BY is deliberate, for performance reasons. But you seem to have reverted to ORDER BY instead. I wonder why? Was the previously existing query giving errors — or not finding the expected results?

I'm just really asking for curiosity's sake, I have no way to accept or reject your PR anyway! 😹

[Banditpong]

I think the issue is related to

Incompatible change: As of MySQL 8.0.13, the deprecated ASC or DESC qualifiers for GROUP BY clauses have been removed. Queries that previously relied on GROUP BY sorting may produce results that differ from previous MySQL versions. To produce a given sort order, provide an ORDER BY clause.

I think the fix should have been.

$q2->addGroup('p.project_id');
$q2->addOrder('f.file_version_id DESC');