Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the renderMode to System when the StatusStrip was selected #12646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Dec 16, 2024

Fixes #12616

Proposed changes

Customer Impact

  • When upgrading a project with StatusStrip from .net8.0 to .net9.0, there will no longer be extra white lines in the Form

Regression?

  • Yes

Risk

  • Minimal

Screenshots

Before

A white line in the dialog when using StatusStrip
image

After

No extra white line the dialog
image

Test methodology

  • Manually

Test environment(s)

  • .net 10.0.0-alpha.1.24606.5
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.00079%. Comparing base (a5281d9) to head (834c874).
Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12646          +/-   ##
====================================================
- Coverage   97.03492%   76.00079%   -21.03414%     
====================================================
  Files           1182        3176        +1994     
  Lines         354561      638946      +284385     
  Branches        5411       47174       +41763     
====================================================
+ Hits          344048      485604      +141556     
- Misses          9724      149838      +140114     
- Partials         789        3504        +2715     
Flag Coverage Δ
Debug 76.00079% <76.47059%> (-21.03414%) ⬇️
integration 18.12917% <0.00000%> (?)
production 49.77513% <63.63636%> (?)
test 97.03577% <100.00000%> (+0.00084%) ⬆️
unit 46.97962% <63.63636%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Dec 17, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Dec 18, 2024
@Tanya-Solyanik
Copy link
Member

Please investigate if the fix can be moved to the lower level rendering code

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📭 waiting-author-feedback The team requires more information from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A unexpected white line in StatusStrip compoent in dotnet 9
2 participants