Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Fix wrong alias-to for tvos AOT packs in net8 workload manifest #110871

Open
wants to merge 1 commit into
base: release/9.0-staging
Choose a base branch
from

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Dec 20, 2024

Customer Impact

  • Customer reported
  • Found internally

While working on #110477 I noticed that we made two mistakes when adding the net8 workload manifest.

  1. Microsoft.NETCore.App.Runtime.AOT.Cross.net8.tvos-arm64 uses the wrong alias-to so on an arm64 macOS host you'd get the x64 package and vice versa
  2. Microsoft.NETCore.App.Runtime.net8.osx-arm64 refers to the Mono runtime package instead of the CoreCLR one.

This will only show up if you target e.g. net8.0-tvos using a net9 sdk and as far as I know the SDK should fetch the correct package during build, it just won't be pre-downloaded to the sdk packs folder.

Regression

  • Yes
  • No

This was introduced in 2d7fe94 but it's only a regression in the sense that it happens when you use the net9 sdk to target net8.0-tvos

Testing

Tested locally by modifying the WorkloadManifest.json and observing the correct pack is installed.

Risk

Low. This just changes the workload manifest for net8 when using a net9 sdk.

@akoeplinger akoeplinger added Servicing-consider Issue for next servicing release review area-Workloads Workloads like wasm-tools labels Dec 20, 2024
@akoeplinger akoeplinger added this to the 9.0.x milestone Dec 20, 2024
@akoeplinger akoeplinger requested a review from lewing as a code owner December 20, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Workloads Workloads like wasm-tools Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant