Document Code Owner Responsibilities and Repo Maintainer Procedures #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
reviewed
Aug 27, 2024
README.md
Outdated
|
|
||
| 1. Create a new issue detailing the break. @mention the appropriate [CODEOWNER](./CODEOWNERS). | ||
| 2. If the break is blocking automatic rebuilds or blocking the development/release of new changes (judgement decision), | ||
| then disable the Dockerfile from building by commenting out the [manifest entry](#manifest). |
There was a problem hiding this comment.
I don't know if commenting out works (with the question of whether comments are supported in JSON by the reader). AFAIK, we haven't tested that scenario. Deletion should probably be the recommendation for now.
There was a problem hiding this comment.
I adjusted the step to delete the manifest entry in 7c327dc.
Co-authored-by: Matt Thalman <[email protected]>
mthalman
approved these changes
Aug 27, 2024
mthalman
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #972