Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review delegate content in the C# programming guide #44046

Merged
merged 4 commits into from
Dec 21, 2024
Merged

Review delegate content in the C# programming guide #44046

merged 4 commits into from
Dec 21, 2024

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Dec 20, 2024 •
edited by github-actions bot
Loading

Fixes #28969
Fixes #30318
Fixes #34636

Commit log:

-Move samples from the /samples folder to the local ./snippets folder.

  • Edits to fix the three open issues
  • Full edit pass, refactor the example code.

Internal previews

📄 File 🔗 Preview link
docs/csharp/programming-guide/delegates/delegates-with-named-vs-anonymous-methods.md Delegates with Named vs. Anonymous Methods (C# Programming Guide)
docs/csharp/programming-guide/delegates/how-to-combine-delegates-multicast-delegates.md "How to combine delegates (Multicast Delegates)"
docs/csharp/programming-guide/delegates/how-to-declare-instantiate-and-use-a-delegate.md How to declare, instantiate, and use a Delegate (C# Programming Guide)
docs/csharp/programming-guide/delegates/index.md docs/csharp/programming-guide/delegates/index
docs/csharp/programming-guide/delegates/using-delegates.md Using Delegates (C# Programming Guide)

@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 20, 2024
@dotnet-policy-service dotnet-policy-service bot added okr-freshness OKR: Freshness of content okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. labels Dec 20, 2024
@BillWagner
Move delegate samples
9c08edd
@BillWagner
Fix the open issues
6c5135d 
- Add an example using an anonymouse method
- Remove the references to C++ function pointers
- Rewrite one heading
@BillWagner BillWagner force-pushed the add-anonymous-function-declaration branch from a1c2040 to 6c5135d Compare December 20, 2024 19:16
@BillWagner
Proofread
966b44f 
Refactor code, proofread and grammar check.

Remove one example. It more or less repeated the previous full example.
@BillWagner BillWagner marked this pull request as ready for review December 20, 2024 21:47
@BillWagner BillWagner requested review from IEvangelist and a team as code owners December 20, 2024 21:47
@BillWagner BillWagner enabled auto-merge (squash) December 21, 2024 14:36
@BillWagner BillWagner merged commit fd386d1 into dotnet:main Dec 21, 2024
8 checks passed
@BillWagner BillWagner deleted the add-anonymous-function-declaration branch December 21, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
dotnet-csharp/svc fundamentals/subsvc okr-freshness OKR: Freshness of content okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
December 2024
2 participants
@BillWagner @gewarren