Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display options control in table #43946

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

timdeschryver
Copy link
Contributor

@timdeschryver timdeschryver commented Dec 11, 2024

Summary

To improve how option controls are formatted, they are now represented in a table instead of a bullet point list.
There's also a anchor link to the linked section, I first added this link to the MSBuild syntax, but I think this version is more clear.

Fixes #42355


Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/compiler-options/errors-warnings.md docs/csharp/language-reference/compiler-options/errors-warnings

@timdeschryver timdeschryver requested review from BillWagner and a team as code owners December 11, 2024 18:39
@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Dec 11, 2024
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timdeschryver

This looks great. I'll :shipit: when the build finishes.

@BillWagner BillWagner enabled auto-merge (squash) December 12, 2024 14:47
auto-merge was automatically disabled December 12, 2024 15:11

Head branch was pushed to by a user without write access

@BillWagner BillWagner enabled auto-merge (squash) December 12, 2024 15:13
@BillWagner BillWagner merged commit 7a95d4c into dotnet:main Dec 12, 2024
8 checks passed
@timdeschryver timdeschryver deleted the issue/42355 branch December 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc lang-reference/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.csproj options are below the fold
2 participants