Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more clarity on member lookup #43932

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Dec 10, 2024

Found while updating the feature spec for the feature. This article didn't clearly state that file local types are preferred over other types with the same name in the file where they are declared.

Also, the file modifier doesn't actually modify the scope, rather, it modifies the visibility. Update the language to match the speclet definition.

Finally, quick edit pass.


Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/keywords/file.md The file modifier

Found while updating the feature spec for the feature. This article didn't clearly state that file local types are preferred over other types with the same name in the file where they are declared.

Also, the `file` modifier doesn't actually modify the *scope*, rather, it modifies the *visibility*. Update the language to match the speclet definition.

Finally, quick edit pass.
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BillWagner BillWagner merged commit 4c158be into dotnet:main Dec 13, 2024
11 checks passed
@BillWagner BillWagner deleted the file-based-lookup branch December 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants