Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to SymUploader and the tasks it provided #15119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Oct 1, 2024

No description provided.

@hoyosjs hoyosjs requested review from mmitche and epananth October 1, 2024 04:10
@hoyosjs
Copy link
Member Author

hoyosjs commented Oct 1, 2024

The other think I can do is leave the targets and make them error out.

@mmitche
Copy link
Member

mmitche commented Oct 2, 2024

I think making them error out makes more sense. There is one hiccup and I'd like @JoeRobich to chime in.

Roslyn has been using the PublishSymbols tasks in dry run mode in PRs to validate their symbol publishing exclusions: See dotnet/roslyn#75096 (comment) for info.

Is there something else we could add to Publish.proj to keep this kind of validation without keeping the task or references?

@JoeRobich
Copy link
Member

We are happy to migrate to something different, as long as we can still validate our publishing config at PR time.

@hoyosjs
Copy link
Member Author

hoyosjs commented Oct 9, 2024

This might take a minute to get to - but there's nothing in the sense that the prior one was not really validating exclusions? It had logging - but there's no error. The tool that v3 uses has a dryrun mode that does some level of validation (it unpacks the nupkg, it checks the files would be fed to symbol.exe, and it can do conversion if you want. However, it does not check files have enough information to be symbol-indexed. That's a concern of symbol.exe now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants