-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual updates 20240913 Binderator bumping fixed #963
base: main
Are you sure you want to change the base?
Conversation
You're correct that we should not be blindly bumping these. In fact, I don't think there's any reason to change these now, as they are all intended to be fixed versions. If we update them to the latest version from NuGet then I think we just need to have the tooling ignore them, and we change them manually on the rare occasion they need to change: |
Exact/pinned version dependencies are rare. I did manually update dependencies every 3-4 updates, because it was manual task and cumbersome.
True for exact/pinned version dependencies which are few. And this is what I did in this PR.
Yes. I did ignore those, but it can happen that some dependencies are not needed anymore and can be removed. see: I did this step of removing all dependencies and let binderator "recalculate" new dependencies twice a year. Ignoring updating dependencies and thus introducing older versions of dependencies could also cause Now that we have everything in one binderator config file, only exact/pinned version dependencies will remain as dependencies, so updating dependencies problem is solved partially by merging to configs. |
I'm not entirely following what you are advocating here:
We only have exact/pinned version dependencies left in
If this is the problem we want to solve, I think we should have |
/asp run |
Currently Binderator bumps even
dependencyOnly = true
which is incorrect resulting in NugetVersions which do not exist and resulting in following config fileconfig.json
This PR fixes this behavior and fetches latest version from nuget.org.
config.json
Added Console output too.