Merge pull request #183 from AArnott/fix182

Fix reference clearing in `Sequence<T>.Reset()`
dotnet · Apr 24, 2020 · d822e69 · d822e69
2 parents 8d40d64 + f585292
commit d822e69
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Nerdbank.Streams.Tests/SequenceTests.cs b/src/Nerdbank.Streams.Tests/SequenceTests.cs
@@ -45,6 +45,15 @@ public void GetMemory_Sizes()
         Assert.Throws<ArgumentOutOfRangeException>(() => seq.GetMemory(-1));
     }
 
+    [Fact]
+    public void Reset_AfterPartialAdvance()
+    {
+        var seq = new Sequence<object>(new MockMemoryPool<object> { Contents = { new object[4] } });
+        seq.Write(new object[3]);
+        seq.AdvanceTo(seq.AsReadOnlySequence.GetPosition(2));
+        seq.Reset();
+    }
+
     [Fact]
     public void MemoryPool_ReleasesReferenceOnRecycle()
     {

diff --git a/src/Nerdbank.Streams/Sequence`1.cs b/src/Nerdbank.Streams/Sequence`1.cs
@@ -396,7 +396,7 @@ internal void Assign(T[] array)
             /// </summary>
             internal void ResetMemory(ArrayPool<T>? arrayPool)
             {
-                this.ClearReferences(this.Start, this.End);
+                this.ClearReferences(this.Start, this.End - this.Start);
                 this.Memory = default;
                 this.Next = null;
                 this.RunningIndex = 0;