-
-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-hide feature added for columns via Exception and Threading diagnoser configuration #2658
base: master
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
What if one benchmark has zero value and another has non-zero value? [Benchmark] public void NoThrow() { }
[Benchmark] public void Throw()
{
try { throw new Exception(); } catch { }
} May need new acceptance tests to validate the table output. |
What behavior do we expect in this case? Something like that? Removed other colums for better readability
|
Yes, that looks like what I would expect. I think with the current code it will display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the sample needs to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's draft, sorry) Just tested new output
At the moment it displays 'NA' instead of '-' if its configured to not display zero. Is it acceptable? And is there any chance you can specify examples of tests for validation table output? case displayExceptions = true(default behavior):
case displayExceptions = false:
|
If any benchmark has a non-zero result, the entire column should display correct results regardless of the configuration. I think you can fix it by passing the configuration values to the metric descriptors and check them in the You can add tests to |
Closes #2629