ExecuteResult: Surface a Data property so the full output can be acce… #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@radical I am currently working on switching the process communication from standard in/out to anonymous pipes: #2092 and I was actually hoping that I'll be able to remove the output parsing/reading. I assume that here you would like to read standard output as it might contain error details? How important is this scenario? |
|
Sometimes the benchmark runs crash with exceptions, or js errors etc, so we definitely need that output. |
adamsitnik
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
LGTM, but I may rename it in #2092 to sth like ParsedStandardOutput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssed.
This would help with exporters that need to access the process output, which might have error details.
cc @adamsitnik