Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] use PublishAot and don't reference ILCompiler in explicit way #2095

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

adamsitnik
Copy link
Member

After recent SDK changes the NativeAOT support got broken again. This time the failure was silent: since we were not setting PublishAot to true, the published app was regular .NET app, not NativeAOT.

This PR sets PublishAot to true and removes the explicit reference to ILCompiler if it's specific version was not provided.

I've tested:

  • support for the old CoreRT bits (we are going to remove it once .NET 7 is released and BDN repo can move to .NET 7 SDK)
  • support for the latests NativeAOT bits
  • support for benchmarking specific NativeAOT version

@AndreyAkinshin we might need to release a new BDN version soon (preferably with #2092 merged as well)

cc @MichalStrehovsky

@adamsitnik adamsitnik added this to the v0.13.3 milestone Sep 2, 2022
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the shuffles.

@adamsitnik adamsitnik merged commit 3a18b18 into master Sep 6, 2022
@adamsitnik adamsitnik deleted the PublishAot branch September 6, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants