Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to not create a powershell window on Windows #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thanhtaivtt
Copy link

When I use your package in Tauri.app. It automatically opens a powershell window to run the command.

So I added an option to prevent it from opening additional windows on Windows.

Can you help me check if this is possible?

Thank you!

@doroved
Copy link
Owner

doroved commented Sep 30, 2024

Hi, I don't have Windows, but I'll try running this code through Github Actions and see if it breaks the tests.

@thanhtaivtt
Copy link
Author

Thanks you!

@BeezBeez
Copy link

BeezBeez commented Dec 9, 2024

Hello, I just tested your crate to build a license system. But having a terminal window showing up a fraction of second will not reassure our users. Can we merge this pull request please ?

Thank you very much for your implementation of machine id crate !

@doroved
Copy link
Owner

doroved commented Dec 9, 2024

Hello, I just tested your crate to build a license system. But having a terminal window showing up a fraction of second will not reassure our users. Can we merge this pull request please ?

Thank you very much for your implementation of machine id crate !

Hi, have you checked to see if this PR is working?
I just don't have a chance to test it as I use mac.

@BeezBeez
Copy link

BeezBeez commented Dec 13, 2024

Hey ! Yep I tested it on Windows 11 and no powershell/terminal window poping-up. 👍
I'm using this branch right now in prod.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants