Ondemand rendering & better trackball #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I'll review it a little bit later :) |
|
Don't merge it, the movie animation does not render because it does not use any controller, sorry. Ill investigate this. |
|
OK! |
|
This is enough, if all modifications to the scene are done via the interface of |
|
Try out my new trackball implementation (3rd one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worldis listening forchangeevents from the controls. On an event it invalidates to infinity so the render loop does not miss an update. Rendering will stop after the last change event plus 100ms.Additionally I changed the trackball behavior a bit, it was quite squishy. Damping now depends on the state, e.g. whether the user is holding/dragging or if it has been released.