Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starkscan-verifier to migration #235

Closed

Conversation

Matth26
Copy link
Contributor

@Matth26 Matth26 commented Apr 15, 2023

Related to issue #208

@tarrencev
Copy link
Contributor

this looks great!

@Matth26
Copy link
Contributor Author

Matth26 commented Apr 16, 2023

I've tested the code in a separate Rust project. Everything is working, except for the fact that starkscan-verifier doesn't handle Cairo1 contracts yet.

I'm currently searching for the best place to insert the verify_class call. Should I add it in the /migration/mod.rs as a method of the Migration struct?

@ponderingdemocritus
Copy link
Contributor

@Matth26 are you still planning on completing this?

@Matth26
Copy link
Contributor Author

Matth26 commented Aug 2, 2023

@Matth26 are you still planning on completing this?
@ponderingdemocritus currently starkscan-verifier doesn't support cairo1 verifying. I'm going to ask the starkscan team if they plan to update it soon.

@Matth26
Copy link
Contributor Author

Matth26 commented Aug 31, 2023

ETA has been asked on the starkscan-verifier repo, but no answer so far
starkscan/starkscan-verifier#8

If you want to clean PR you can close it and I'll reopen it when api is working

@Irajsavad
Copy link

1 similar comment
@Irajsavad
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants