Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: 修复缺少 vcruntime 导致导入 napi-rs 编译的原生模块失败的问题 #415

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

starknt
Copy link
Contributor

@starknt starknt commented Dec 9, 2024

Ⅰ. 描述此PR的作用:

bugfix: 修复缺少 vcruntime 导致导入 napi-rs 编译的原生模块失败的问题

Ⅱ. 此PR修复了哪个issue吗?

fixes #409
fixes #413
fixes #414

Ⅲ. 引用

napi-rs/napi-rs#1341 (comment)

@starknt
Copy link
Contributor Author

starknt commented Dec 9, 2024

感觉可以先发布一个1.9.0

@starknt starknt changed the title bugfix: 修复缺少vcruntime导致导入napi-rs模块失败的问题 bugfix: 修复缺少vcruntime导致导入napi-rs编译的原生模块失败的问题 Dec 9, 2024
@wangliang181230
Copy link
Contributor

没事,我最后再发一个 2.0.0-Pre-Release 版本。

@wangliang181230 wangliang181230 changed the title bugfix: 修复缺少vcruntime导致导入napi-rs编译的原生模块失败的问题 bugfix: 修复缺少 vcruntime 导致导入 napi-rs 编译的原生模块失败的问题 Dec 9, 2024
@wangliang181230
Copy link
Contributor

这个PR,已经OK了是吧?

@wangliang181230 wangliang181230 added this to the 2.0.0 milestone Dec 9, 2024
@wangliang181230 wangliang181230 added Bugfix 修复BUG的PR v2.0.0 2.0.0版本 OS: Windows Windows操作系统 labels Dec 9, 2024
@starknt
Copy link
Contributor Author

starknt commented Dec 9, 2024 via email

@wangliang181230
Copy link
Contributor

好的。😀

@wangliang181230 wangliang181230 merged commit 4daeb26 into docmirror:master Dec 9, 2024
3 checks passed
@starknt
Copy link
Contributor Author

starknt commented Dec 10, 2024

没事,我最后再发一个 2.0.0-Pre-Release 版本。

可以把 @starknt/shutdown-handler-napipnpmsupportedArchitectures配置移植回1.9.0版本,修复1.8.9的问题

@wangliang181230
Copy link
Contributor

主要没有太多精力去维护多版本。还是继续发2.0.0的测试或预发布版本吧。

@wangliang181230
Copy link
Contributor

wangliang181230 commented Dec 10, 2024

然后继续去解决2.0.0在多个环境的兼容性问题。
2.0.0,计划是把兼容性优先级提高些。

@wangliang181230
Copy link
Contributor

@starknt
问下,electron 有没有页面内容检索功能啊?类似于浏览器的 Ctrl+F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 修复BUG的PR OS: Windows Windows操作系统 v2.0.0 2.0.0版本
Projects
None yet
2 participants