Some minor improvements in the documentation and code examples #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanterno
changed the title
lanterno
force-pushed
the
docs/improves-documentation-2
branch
from
081c8b8 to
468dd59
Compare
lanterno
changed the title
This is important to indicate to the user that constructing the ProofSpec is a bit different for verifiers and doesn't include witnesses.
It makes more sense here to say null messages rather than varying number of messages which would indicate that the the count of messages being encoded in the signature changes.
lanterno
force-pushed
the
docs/improves-documentation-2
branch
from
468dd59 to
e8570f0
Compare
lovesh
requested changes
Nov 27, 2024
lovesh
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some minor improvements to the documentation.
But it changes the "BBS signature over varying number of messages" section significantly. Please review it, and let me know if I understand that feature correctly and renamed it well.
part of work towards #36