Docs and typedoc integration #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lovesh <[email protected]>
Open
lanterno
reviewed
Nov 19, 2024
lanterno
reviewed
Nov 19, 2024
Signed-off-by: lovesh <[email protected]>
lanterno
reviewed
Nov 20, 2024
src/anonymous-credentials/schema.ts
Outdated
| useDefaults: boolean; | ||
| defaultMinimumInteger: number; | ||
| defaultMinimumDate: number; | ||
| defaultDecimalPlaces: number; | ||
| } | ||
|
|
||
| export const DefaultSchemaParsingOpts: ISchemaParsingOpts = { | ||
| useDefaults: false, | ||
| useDefaults: false, |
There was a problem hiding this comment.
Is the space here at the beginning of the line intended?
lanterno
reviewed
Nov 20, 2024
| @@ -20,10 +20,10 @@ export class Responses extends BytearrayWrapper {} | |||
|
|
|||
| export class HashedKeys extends BytearrayWrapper {} | |||
|
|
|||
| export class Participant { | |||
| // Id of this participant | |||
| export class BaseOTParticipant { | |||
There was a problem hiding this comment.
This is probably my lack of understanding here, but I don't see this class BaseOTParticipant used anywhere in the tests or in other places in the code.
|
@lovesh Great PR! and special thanks for all the documentation on the anonymous credentials. I didn't manage to go through it all, but I'll take some time later to try the examples. |
Signed-off-by: lovesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.