bake: split definition into two files #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Oct 28, 2023
crazy-max
commented
Oct 28, 2023
Merged
Closed
3 tasks
crazy-max
force-pushed
the
split-bake-file
branch
4 times, most recently
from
5702641 to
f2a2ebe
Compare
|
@tonistiigi As discussed keep |
tonistiigi
reviewed
Nov 22, 2023
UPGRADE.md
Outdated
| > **Note** | ||
| > | ||
| > `bake-file` output is still available for backward compatibility, but it's | ||
| > recommended to use `bake-file-tags` and `bake-file-labels` outputs instead. |
There was a problem hiding this comment.
Why is this recommended? I would more describe it as "alternatively, you can use the individual files that only set tags or labels".
There was a problem hiding this comment.
Removed this section and added note in the README for the alternative syntax:
There was a problem hiding this comment.
It still suggests multiple files as a recommended path, what I don't understand as it is more complicated way to use the action.
There was a problem hiding this comment.
This was to avoid users getting confused if they want to set annotations in follow-up with #352 (see https://github.com/crazy-max/docker-metadata-action/tree/annotations-alt#annotations) but that seems right to still make bake-file the goto behavior. Updated to keep current syntax.
crazy-max
force-pushed
the
split-bake-file
branch
from
f2a2ebe to
5f1b68f
Compare
Allows to either include tags or labels or both definitions. Keep bake-file output for backward compatibility. Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
split-bake-file
branch
from
5f1b68f to
9bdb15d
Compare
tonistiigi
approved these changes
Nov 27, 2023
renovate bot
referenced
this pull request
in 4m-mazi/gh-test
Nov 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/metadata-action](https://togithub.com/docker/metadata-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/metadata-action (docker/metadata-action)</summary> ### [`v5.1.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.1.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.0.0...v5.1.0) #### What's Changed - Annotations support by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/352](https://togithub.com/docker/metadata-action/pull/352) - Split bake definition into two files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/353](https://togithub.com/docker/metadata-action/pull/353) - Allow images input to be empty to output bare tags by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/358](https://togithub.com/docker/metadata-action/pull/358) - Bump [@​actions/github](https://togithub.com/actions/github) from 5.1.1 to 6.0.0 in [https://github.com/docker/metadata-action/pull/348](https://togithub.com/docker/metadata-action/pull/348) - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.17.3 to 7.23.2 in [https://github.com/docker/metadata-action/pull/350](https://togithub.com/docker/metadata-action/pull/350) - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.12.0 to 0.14.0 in [https://github.com/docker/metadata-action/pull/349](https://togithub.com/docker/metadata-action/pull/349) [https://github.com/docker/metadata-action/pull/357](https://togithub.com/docker/metadata-action/pull/357) - Bump csv-parse from 5.5.0 to 5.5.2 in [https://github.com/docker/metadata-action/pull/346](https://togithub.com/docker/metadata-action/pull/346) - Bump semver from 7.5.3 to 7.5.4 in [https://github.com/docker/metadata-action/pull/335](https://togithub.com/docker/metadata-action/pull/335) **Full Changelog**: docker/metadata-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Mogyuchi/gh-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
arnfinn
referenced
this pull request
in Rapporteket/docker
Jan 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/metadata-action](https://togithub.com/docker/metadata-action) | action | minor | `v5.0.0` -> `v5.4.0` | --- ### Release Notes <details> <summary>docker/metadata-action (docker/metadata-action)</summary> ### [`v5.4.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.4.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.3.0...v5.4.0) - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.15.0 to 0.16.0 in [https://github.com/docker/metadata-action/pull/369](https://togithub.com/docker/metadata-action/pull/369) - Bump csv-parse from 5.5.2 to 5.5.3 in [https://github.com/docker/metadata-action/pull/365](https://togithub.com/docker/metadata-action/pull/365) **Full Changelog**: docker/metadata-action@v5.3.0...v5.4.0 ### [`v5.3.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.3.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.2.0...v5.3.0) - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.14.0 to 0.15.0 in [https://github.com/docker/metadata-action/pull/363](https://togithub.com/docker/metadata-action/pull/363) (fixes [#​362](https://togithub.com/docker/metadata-action/issues/362)) **Full Changelog**: docker/metadata-action@v5.2.0...v5.3.0 ### [`v5.2.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.2.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.1.0...v5.2.0) - Custom annotations support by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/361](https://togithub.com/docker/metadata-action/pull/361) **Full Changelog**: docker/metadata-action@v5.1.0...v5.2.0 ### [`v5.1.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.1.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.0.0...v5.1.0) - Annotations support by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/352](https://togithub.com/docker/metadata-action/pull/352) - Split bake definition into two files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/353](https://togithub.com/docker/metadata-action/pull/353) - Allow images input to be empty to output bare tags by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/358](https://togithub.com/docker/metadata-action/pull/358) - Bump [@​actions/github](https://togithub.com/actions/github) from 5.1.1 to 6.0.0 in [https://github.com/docker/metadata-action/pull/348](https://togithub.com/docker/metadata-action/pull/348) - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.17.3 to 7.23.2 in [https://github.com/docker/metadata-action/pull/350](https://togithub.com/docker/metadata-action/pull/350) - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.12.0 to 0.14.0 in [https://github.com/docker/metadata-action/pull/349](https://togithub.com/docker/metadata-action/pull/349) [https://github.com/docker/metadata-action/pull/357](https://togithub.com/docker/metadata-action/pull/357) - Bump csv-parse from 5.5.0 to 5.5.2 in [https://github.com/docker/metadata-action/pull/346](https://togithub.com/docker/metadata-action/pull/346) - Bump semver from 7.5.3 to 7.5.4 in [https://github.com/docker/metadata-action/pull/335](https://togithub.com/docker/metadata-action/pull/335) **Full Changelog**: docker/metadata-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Rapporteket/docker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to either include tags or labels or both definitions.
Keep
bake-fileoutput with tags and labels for backward compatibility.