Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Fix: no connect & start if not recreated #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xihan88
Copy link
Contributor

@xihan88 xihan88 commented Jan 24, 2018

Signed-off-by: xi.han [email protected]
This is a simple way to fix #494 . However I believe there are better ways for this issue. For example recreateIfNeeded() could return a bool showing whether the service was updated or not.

@xihan88
Copy link
Contributor Author

xihan88 commented Jan 24, 2018

@vdemeester Could you help me to trigger the test again? Thanks!

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compose Up fails trying to recreate containers when not needed
2 participants