This repository has been archived by the owner on Jun 16, 2021. It is now read-only.
Add ServiceNames() to APIProject #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Observed -------------- project.APIProject doesn't provide a method to get the service names define in a project. You cannot get service names when you use GetSreviceConfig() and other methods of the interface. Proposed Resolution ------------------- We could add a method GetServiceConfigs() which returns the *ServiceConfigs owned by the concrete struct (project.Project). However, since the strcut already has ServiceConfigs property, we cannot add a new method with the same name. In this commit, we add a new method just returns the list of service names instead of returning the *ServiceConfigs itself. Signed-off-by: Iwasaki Yudai <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Observed
project.APIProject doesn't provide a method to get the service names
define in a project.
You cannot get service names when you use GetSreviceConfig() and other
methods of the interface.
Proposed Resolution
We could add a method GetServiceConfigs() which returns the
*ServiceConfigs owned by the concrete struct (project.Project).
However, since the strcut already has ServiceConfigs property, we cannot add a new method with the same name.
In this commit, we add a new method just returns the list of service
names instead of returning the *ServiceConfigs itself.