Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apache (httpd) haproxy and wordpress to GHA #10

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

LaurentGoderre
Copy link
Member

No description provided.

@whalelines
Copy link
Collaborator

Any idea what this will do to the timing of the meta build?

@LaurentGoderre
Copy link
Member Author

@whalelines it will slow it down. Im not sure by how much though

@whalelines
Copy link
Collaborator

Right, and isn't it already failing to complete by the time the next one is scheduled?

@whalelines
Copy link
Collaborator

Well, it seems that issue has resolved.

Copy link
Collaborator

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whalelines
Copy link
Collaborator

Have you tested timing locally?

@LaurentGoderre
Copy link
Member Author

I never got anywhere near the time that the script takes on the build machine

@whalelines
Copy link
Collaborator

I mean relatively. So if adding these three images locally makes it go from 7 minutes to 20 minutes, we can estimate it increased the time about threefold on the Jenkins runner.

@LaurentGoderre
Copy link
Member Author

😓 it increases 50%

Before:

.scripts/builds.sh sources.json > /dev/null  177.41s user 58.04s system 20% cpu 19:09.06 total

After:

.scripts/builds.sh sources.json > /dev/null  254.98s user 78.18s system 29% cpu 18:43.96 total

@whalelines
Copy link
Collaborator

The meta job is scheduled every hour at present and the Builds stage takes 20–22 minutes on average, with an additional 2.5–3 minutes for the other stages. So increasing the build stage by 50% should be safe, making it 30–35 minutes, with the whole job finishing in less than 40 minutes. But we'll need to do something about the scaling soon.

@LaurentGoderre
Copy link
Member Author

Yeah. This almost completes the leaf docker managed ones so it would be a good point to address scaling as we bring in community ones.

@tianon
Copy link
Member

tianon commented Dec 13, 2023

With docker-library/meta-scripts#5, this should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants