-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added apache (httpd) haproxy and wordpress to GHA #10
Conversation
Any idea what this will do to the timing of the meta build? |
@whalelines it will slow it down. Im not sure by how much though |
Right, and isn't it already failing to complete by the time the next one is scheduled? |
Well, it seems that issue has resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you tested timing locally? |
I never got anywhere near the time that the script takes on the build machine |
I mean relatively. So if adding these three images locally makes it go from 7 minutes to 20 minutes, we can estimate it increased the time about threefold on the Jenkins runner. |
😓 it increases 50% Before:
After:
|
The meta job is scheduled every hour at present and the Builds stage takes 20–22 minutes on average, with an additional 2.5–3 minutes for the other stages. So increasing the build stage by 50% should be safe, making it 30–35 minutes, with the whole job finishing in less than 40 minutes. But we'll need to do something about the scaling soon. |
Yeah. This almost completes the leaf docker managed ones so it would be a good point to address scaling as we bring in community ones. |
With docker-library/meta-scripts#5, this should be fine. |
No description provided.