Switch to consuming JSON from GitHub for "latest commit" #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, `curl -L https://github.com/docker/docker/commits/master/hack/dind.atom` has recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicit `Accept:` header (the only explicit JSON one that seems to work) and uses `jq` to determine the latest `hack/dind` commit instead of hacking up the XML via `grep`+`awk`.
tianon
added a commit
to tianon/dockerfiles
that referenced
this pull request
Jan 8, 2024
For some reason, https://github.com/xxx/yyy/commits/HEAD/zzz.atom has recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicit `Accept:` header (the only explicit JSON one that seems to work) and uses `jq` to determine the latest `hack/dind` commit instead of hacking up the XML via `grep`+`awk`. See also docker-library/docker#472
yosifkit
approved these changes
Jan 9, 2024
tianon
added a commit
to docker-library/python
that referenced
this pull request
Jan 9, 2024
For some reason, https://github.com/xxx/yyy/commits/HEAD/zzz.atom has recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicit `Accept:` header (the only explicit JSON one that seems to work) and uses `jq` to determine the latest commit instead of hacking up the XML via `grep`+`awk`. See also docker-library/docker#472 (Additionally, this switches the file to use `wget` consistently instead of a mix of `wget` and `curl`)
tianon
added a commit
to docker-library/oi-janky-groovy
that referenced
this pull request
Jan 9, 2024
For some reason, https://github.com/xxx/yyy/commits/HEAD/zzz.atom has recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicit `Accept:` header (the only explicit JSON one that seems to work) and uses `jq` to determine the latest commit instead of hacking up the XML via `grep`+`awk`. See also docker-library/docker#472 (Additionally, this switches the file to use `wget` consistently instead of a mix of `wget` and `curl`)
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 11, 2024
Changes: - docker-library/docker@72a378e: Update 25-rc to compose 2.24.0 - docker-library/docker@ef1774b: Update 24 to compose 2.24.0 - docker-library/docker@76e5e78: Merge pull request docker-library/docker#472 from infosiftr/github-atom-json - docker-library/docker@e8fb8d7: Switch to consuming JSON from GitHub for "latest commit"
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 12, 2024
Changes: - docker-library/docker@a4e8aab: Update 25-rc to buildx 0.12.1 - docker-library/docker@e941e9d: Update 24 to buildx 0.12.1 - docker-library/docker@72a378e: Update 25-rc to compose 2.24.0 - docker-library/docker@ef1774b: Update 24 to compose 2.24.0 - docker-library/docker@76e5e78: Merge pull request docker-library/docker#472 from infosiftr/github-atom-json - docker-library/docker@e8fb8d7: Switch to consuming JSON from GitHub for "latest commit"
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 13, 2024
Changes: - docker-library/docker@5fcc1d9: Update 25-rc to 25.0.0-rc.2 - docker-library/docker@a4e8aab: Update 25-rc to buildx 0.12.1 - docker-library/docker@e941e9d: Update 24 to buildx 0.12.1 - docker-library/docker@72a378e: Update 25-rc to compose 2.24.0 - docker-library/docker@ef1774b: Update 24 to compose 2.24.0 - docker-library/docker@76e5e78: Merge pull request docker-library/docker#472 from infosiftr/github-atom-json - docker-library/docker@e8fb8d7: Switch to consuming JSON from GitHub for "latest commit"
ProActiveSpirit
pushed a commit
to ProActiveSpirit/python
that referenced
this pull request
Mar 1, 2024
For some reason, https://github.com/xxx/yyy/commits/HEAD/zzz.atom has recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicit `Accept:` header (the only explicit JSON one that seems to work) and uses `jq` to determine the latest commit instead of hacking up the XML via `grep`+`awk`. See also docker-library/docker#472 (Additionally, this switches the file to use `wget` consistently instead of a mix of `wget` and `curl`)
martin-g
pushed a commit
to martin-g/docker-official-images
that referenced
this pull request
Apr 3, 2024
Changes: - docker-library/docker@5fcc1d9: Update 25-rc to 25.0.0-rc.2 - docker-library/docker@a4e8aab: Update 25-rc to buildx 0.12.1 - docker-library/docker@e941e9d: Update 24 to buildx 0.12.1 - docker-library/docker@72a378e: Update 25-rc to compose 2.24.0 - docker-library/docker@ef1774b: Update 24 to compose 2.24.0 - docker-library/docker@76e5e78: Merge pull request docker-library/docker#472 from infosiftr/github-atom-json - docker-library/docker@e8fb8d7: Switch to consuming JSON from GitHub for "latest commit"
SammyEnigma
pushed a commit
to SammyEnigma/dockerfiles
that referenced
this pull request
Jun 2, 2024
For some reason, https://github.com/xxx/yyy/commits/HEAD/zzz.atom has recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicit `Accept:` header (the only explicit JSON one that seems to work) and uses `jq` to determine the latest `hack/dind` commit instead of hacking up the XML via `grep`+`awk`. See also docker-library/docker#472
Preston-Adams
pushed a commit
to Preston-Adams/python-field
that referenced
this pull request
Aug 18, 2024
For some reason, https://github.com/xxx/yyy/commits/HEAD/zzz.atom has recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicit `Accept:` header (the only explicit JSON one that seems to work) and uses `jq` to determine the latest commit instead of hacking up the XML via `grep`+`awk`. See also docker-library/docker#472 (Additionally, this switches the file to use `wget` consistently instead of a mix of `wget` and `curl`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
curl -L https://github.com/docker/docker/commits/master/hack/dind.atomhas recently changed from returning XML by default to returning JSON, which from https://docs.github.com/en/rest/activity/feeds?apiVersion=2022-11-28 seems like it's intentional, so this adds an explicitAccept:header (the only explicit JSON one that seems to work) and usesjqto determine the latesthack/dindcommit instead of hacking up the XML viagrep+awk.