-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Alpine 3.19 #461
Conversation
Ah, #437 by itself is not correct/complete, but it is a great thing to surface and a big problem for this image (surfacing a larger problem with iptables vs nftables, especially as it relates to network namespaces / Docker-in-Docker). 😞 |
That seems like a rather large blocking issue then. I'll mark this as draft in the meantime, so anyone interested can still subscribe and track progress. |
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/47102 changes the default iptables backend to nf_tables. To prepare for the change (and to make sure it's not forgotten once DinD is updated), load nf_tables into the kernel.
0c7cceb
to
18bbfb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect IMO! ❤️
Changes: - docker-library/docker@0411c8f: Merge pull request docker-library/docker#461 from jnoordsij/update-alpine-3.19 - docker-library/docker@18bbfb7: Update to Alpine 3.19 - docker-library/docker@4c2674d: Remove ip_tables in favor of nf_tables in dockerd entrypoint fallback - docker-library/docker@07fb6c2: Load nf_tables in preparation of Alpine 3.19
PR docker-library#461 updated Alpine to 3.19 and made a change to load the nf_tables kernel module if needed. However, as demonstrated by docker-library#463 and docker-library#464 this might break when the host system doesn't have the nf_tables module available. In that case, we should still try to load the ip_tables module and symlink /sbin/iptables to xtables-legacy-multi. Signed-off-by: Albin Kerouanton <[email protected]>
This updates Alpine to the latest stable version: 3.19.
See also https://alpinelinux.org/posts/Alpine-3.19.0-released.html.
Edit: This is currently blocked as it requires additional upstream support for
nftables
; see also comment below and #437.Closes: #437