Avoid unnecessary token skip #642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After parsing the statement and construct the 'between operator', there is no need to call statement.skip(). This bug may cause the query ignore the eq filter when both eq and range filters exist together. For example queryset.filter(field_a=xxx).filter(field_b__range=[aaa, bbb])
nesdis
force-pushed
the
master
branch
2 times, most recently
from
7f02049 to
b99adcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After parsing the statement and constructing the 'between operator', there is no need to call statement.skip().
This bug may cause the query ignores the eq filter when both eq and range filters exist. For example
the field_a=xxx may be ignored