Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared/components): Icon 컴포넌트 추가 #96

Merged
merged 1 commit into from
Mar 17, 2024
Merged

feat(shared/components): Icon 컴포넌트 추가 #96

merged 1 commit into from
Mar 17, 2024

Conversation

sukvvon
Copy link
Collaborator

@sukvvon sukvvon commented Mar 17, 2024

이슈 번호

작업한 목록을 작성해 주세요

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

  • Icon 컴포넌트는 두 가지 케이스로 반환합니다!
  • as prop의 type이 string 즉 div, a 태그와 같은 것이 아닐 경우 이미 만들어진 React.ReactNode의 형식인 경우 형식 그대로 반환합니다!
  • 위 경우가 아닌 경우 children 값들을 자식 element로 하여 반환합니다!
  • 추후 props 없이 Icon 컴포넌트를 사용한 경우를 의미하는 fallback 요소를 추가할 계획입니다!

@sukvvon sukvvon requested a review from heyman333 as a code owner March 17, 2024 10:57
@sukvvon sukvvon linked an issue Mar 17, 2024 that may be closed by this pull request
1 task
Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
favolink-web ✅ Ready (Inspect) Visit Preview Mar 17, 2024 10:58am

@github-actions github-actions bot added the feat 새로운 기능 추가 또는 기존 기능의 확장 label Mar 17, 2024
Copy link

Thanks for the contribution!
I have applied any labels matching special text in your title and description.

Please review the labels and make any necessary changes.

@sukvvon sukvvon merged commit 79ed75b into main Mar 17, 2024
8 checks passed
@sukvvon sukvvon deleted the feat/86 branch March 17, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 추가 또는 기존 기능의 확장
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(shared/components): Icon 컴포넌트 추가
1 participant