Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui/react/styles/utilities): dynamic, enum 속성의 css.ts 파일 추가 #238

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

sukvvon
Copy link
Collaborator

@sukvvon sukvvon commented Jul 16, 2024

이슈 번호

작업한 목록을 작성해 주세요

  • vanilla-extract의 style, styleVariants로 자주 사용되는 css 속성들을 css.ts파일로 생성합니다.
  • width, height와 같이 number | string으로 enum으로 오는 값이 아닌 경우 dynamic으로 생성합니다.
  • 이미 생성된 값은 각 dynamic, enum 파일 내부로 이동시킵니다.
    • dynamic은 vanilla-extract/dynamic을 위한 것입니다.

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

@sukvvon sukvvon requested a review from heyman333 as a code owner July 16, 2024 13:45
@sukvvon sukvvon linked an issue Jul 16, 2024 that may be closed by this pull request
26 tasks
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
favolink-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 1:45pm

@github-actions github-actions bot added the feat 새로운 기능 추가 또는 기존 기능의 확장 label Jul 16, 2024
@sukvvon sukvvon merged commit 7ba4d0f into main Jul 16, 2024
9 checks passed
@sukvvon sukvvon deleted the feat/237 branch July 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 추가 또는 기존 기능의 확장
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ui/react/styles/utilities): dynamic, enum 속성의 css.ts 파일 추가
1 participant