Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui/react): Portal 단순화, ModalPortal, ModalContext 변경 및 개편 #206

Merged
merged 13 commits into from
Jul 5, 2024
Merged

feat(ui/react): Portal 단순화, ModalPortal, ModalContext 변경 및 개편 #206

merged 13 commits into from
Jul 5, 2024

Conversation

sukvvon
Copy link
Collaborator

@sukvvon sukvvon commented Jul 5, 2024

이슈 번호

작업한 목록을 작성해 주세요

  • CloseIcon을 추가합니다.
  • ModalPortal, ModalTrigger 추가한 후, ModalContext 속성을 단순화합니다.
  • 종속된 Portal style을 제거하고, Portal 로직을 단순화합니다.

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

sukvvon added 13 commits July 5, 2024 20:42
@sukvvon
feat(ui/react/modal): ModalClose 컴포넌트 추가
7a064ca
@sukvvon
refactor(ui/react/modal): ModalOverlay style transform 활용하여 변경
7a47faa
@sukvvon
refactor(ui/react/modal): ModalContent 내부 ModalOverlay 제거
a077115
@sukvvon
refactor(ui/react/modal): ModalOverlay style inset으로 단축, recipe 제거
068abee
@sukvvon
feat(ui/react/modal): 변경된 style 반영, onOpenChange 속성 내부 추가
ea3a5bb
@sukvvon
feat(ui/react/portal): Portal 간소화, 종속되는 styles 제거
798778b
@sukvvon
feat(ui/react/modal): ModalPortal 추가
bfcf52d
@sukvvon
refactor(ui/react/modal): ModalTitle style textAlign으로 변경, 적용
0c0d272
@sukvvon
feat(ui/react/icons): CloseIcon 추가
29b62cf
@sukvvon
feat(ui/react/modal): ModalTopbar 텍스트 아이콘으로 변경
ef23952
@sukvvon
feat(ui/react/modal): ModalTrigger 추가
0300a57
@sukvvon
feat(ui/react/modal): ModalContextValue 속성 단순화
dcc15a3
@sukvvon
feat(ui/react/modal): ModalContext 반영, 내외부 onOpen, onOpenChange 속성 받게 추가
fea0317
@sukvvon sukvvon requested a review from heyman333 as a code owner July 5, 2024 12:10
@sukvvon sukvvon linked an issue Jul 5, 2024 that may be closed by this pull request
feat(ui/react): Portal 단순화, ModalPortal, ModalContext 변경 및 개편 #200
Closed
3 tasks
@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
favolink-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 0:10am

@github-actions github-actions bot added feat 새로운 기능 추가 또는 기존 기능의 확장 refactor 코드 리팩토링, 구조 개선, 성능 향상 등 기능 변경 없이 코드 자체를 개선하는 작업 labels Jul 5, 2024
@sukvvon sukvvon merged commit 6405453 into main Jul 5, 2024
7 checks passed
@sukvvon sukvvon deleted the feat/200 branch July 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyman333 heyman333 Awaiting requested review from heyman333 heyman333 is a code owner

Assignees

@sukvvon sukvvon

Labels
feat 새로운 기능 추가 또는 기존 기능의 확장 refactor 코드 리팩토링, 구조 개선, 성능 향상 등 기능 변경 없이 코드 자체를 개선하는 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(ui/react): Portal 단순화, ModalPortal, ModalContext 변경 및 개편
1 participant
@sukvvon