Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui/system): slottable 개념 도입 #199

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat(ui/system): slottable 개념 도입 #199

merged 3 commits into from
Jun 20, 2024

Conversation

sukvvon
Copy link
Collaborator

@sukvvon sukvvon commented Jun 20, 2024 •
edited
Loading

이슈 번호

작업한 목록을 작성해 주세요

  • Slottable 컴포넌트를 추가합니다.
  • Slottable 개념을 createPolymorphicComponent 함수에 적용합니다.

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

  • 기존 onlyChild일 경우 즉 children 내부 element가 하나일 경우만 asChild가 가능하도록 하였습니다. 하지만 slottable 개념을 도입하여 children의 element가 여러개더라도 컴포넌트 내부 children(이것 또한 element가 하나인 경우)을 asChild로 받아서 동작하도록 합니다.

@sukvvon sukvvon requested a review from heyman333 as a code owner June 20, 2024 14:27
@sukvvon sukvvon linked an issue Jun 20, 2024 that may be closed by this pull request
feat(ui/system): slottable 개념 도입 #198
Closed
2 tasks
@vercel Vercel
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
favolink-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:27pm

@github-actions github-actions bot added the feat 새로운 기능 추가 또는 기존 기능의 확장 label Jun 20, 2024
@sukvvon sukvvon merged commit 3a46978 into main Jun 20, 2024
8 checks passed
@sukvvon sukvvon deleted the feat/198 branch June 20, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyman333 heyman333 Awaiting requested review from heyman333 heyman333 is a code owner

Assignees

@sukvvon sukvvon

Labels
feat 새로운 기능 추가 또는 기존 기능의 확장
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(ui/system): slottable 개념 도입
1 participant
@sukvvon