Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shared/system): extractProps 함수 추가 #157

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feat(shared/system): extractProps 함수 추가 #157

merged 1 commit into from
Apr 23, 2024

Conversation

sukvvon
Copy link
Collaborator

@sukvvon sukvvon commented Apr 23, 2024 •
edited
Loading

이슈 번호

작업한 목록을 작성해 주세요

  • extractProps 함수를 추가합니다!

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

  • 코드는 정상적으로 동작하는 것으로 보여지지만 type 관련해서는 아직 미흡한 부분이 존재합니다. (Omit 되어야할 prop들이 실제론 제거가 되어있지만 type은 omit이 되어있지 않은 이슈), flexStyleProps, flexStyleVars와 같은 상수를 정의할 때 사용되는 type을 extractProps 함수 내부적으로 imort하여 Omit을 통해 제거할 예정입니다!

@sukvvon sukvvon requested a review from heyman333 as a code owner April 23, 2024 13:27
@sukvvon sukvvon linked an issue Apr 23, 2024 that may be closed by this pull request
feat(shared/system): extractProps 함수 추가 #145
Closed
1 task
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
favolink-web ✅ Ready (Inspect) Visit Preview Apr 23, 2024 1:27pm

@github-actions github-actions bot added the feat 새로운 기능 추가 또는 기존 기능의 확장 label Apr 23, 2024
@sukvvon sukvvon merged commit 467df01 into main Apr 23, 2024
8 checks passed
@sukvvon sukvvon deleted the feat/145 branch April 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyman333 heyman333 Awaiting requested review from heyman333 heyman333 is a code owner

Assignees

@sukvvon sukvvon

Labels
feat 새로운 기능 추가 또는 기존 기능의 확장
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(shared/system): extractProps 함수 추가
1 participant
@sukvvon